Pull request for #46 "Timestamps are incorrectly parsed in local time"#47
Merged
ixti merged 2 commits intonodeca:masterfrom Jul 6, 2012
Merged
Pull request for #46 "Timestamps are incorrectly parsed in local time"#47ixti merged 2 commits intonodeca:masterfrom
ixti merged 2 commits intonodeca:masterfrom
Conversation
added 2 commits
July 6, 2012 14:31
… happens to be GMT
ixti
added a commit
that referenced
this pull request
Jul 6, 2012
Pull request for #46 "Timestamps are incorrectly parsed in local time"
Contributor
|
Thank you! :)) |
Contributor
Author
|
@ixti Thanks, I'd appreciate if you could publish this to NPM and let me know the package version so I can drop my fork ;) |
Contributor
|
@caolan We have published js-yaml 1.0.1 with your fix :)) Thanks once again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the test and fix as separate commits so you can confirm if you wish. The only tricky part I've not tackled is failing the test (pre-fix) if your timezone happens to be GMT.