Fix for issue #468 includes passing test#469
Merged
puzrin merged 7 commits intonodeca:masterfrom Feb 26, 2019
diberry:fix-468
Merged
Fix for issue #468 includes passing test#469puzrin merged 7 commits intonodeca:masterfrom diberry:fix-468
puzrin merged 7 commits intonodeca:masterfrom
diberry:fix-468
Conversation
puzrin
reviewed
Feb 24, 2019
Member
puzrin
left a comment
puzrin
left a comment
There was a problem hiding this comment.
LGTM in general, but need coding style fix to pass linter.
Run make test local to be sure. If you don't have make, run makefile commands manually.
Contributor
Author
|
@puzrin I ran from Makefile and saw the linter errors but wanted feedback before applying linting fixes. |
puzrin
reviewed
Feb 24, 2019
Contributor
Author
|
#sign-off |
puzrin
reviewed
Feb 24, 2019
Contributor
Author
|
@puzrin Please let me know if there are other changes you need. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.