refactor MarkedYAMLError.toString#33
Merged
ixti merged 1 commit intonodeca:masterfrom Dec 20, 2011
Merged
Conversation
Split the toString method up so that there is now toStringFull() and
toStringCompact(), and toString(compact) delegates off depending on
whether compact was passed in.
The reason for this is because I have tweaked the display of the compact
error messages, and rather than adding more logic to toString() it
seemed more sensible to split it up.
Compact error messages now look like:
Error on line 7, col 1: could not found expected ':'
The motivation for this change is increased parsability and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I tweaked the output of compact errors. The commit message (copied in below) explains it pretty well. Let me know if there is anything I can do :-)
Split the toString method up so that there is now toStringFull() and
toStringCompact(), and toString(compact) delegates off depending on
whether compact was passed in.
The reason for this is because I have tweaked the display of the compact
error messages, and rather than adding more logic to toString() it
seemed more sensible to split it up.
Compact error messages now look like:
The motivation for this change is increased parsability and readability.