Add --compact option to emit errors on one line and use nomnom#32
Closed
scrooloose wants to merge 2 commits intonodeca:masterfrom
Closed
Add --compact option to emit errors on one line and use nomnom#32scrooloose wants to merge 2 commits intonodeca:masterfrom
scrooloose wants to merge 2 commits intonodeca:masterfrom
Conversation
Contributor
|
Thanks for your pull request. But your change makes sense, so we have moved I'll put your changes to Error classes in next few moments. |
ixti
added a commit
that referenced
this pull request
Dec 20, 2011
Thanks to @scrooloose. See #32 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 changes here.
1 - Use nomnom to parse command line args
2. Allow the user to specify --compact which causes error messages to be displayed on one line
The reason for wanting one line error messages is to make it easier to parse so that it can be incorporated into syntasitc, a syntax checker plugin for vim (https://github.com/scrooloose/syntastic).
In this patch, some error message content is omitted when --compact is used. Namely
context,contextMark, and the error snippet and pointer. To illustrate, here is an error without --compact:and here is the same error with --compact
I should probably note that I am a n00b at javascript so if you want to pull then its probably a good idea to review the changes pretty closely, and if i have missed something or if something could be done better then just comment and ill take care of it.