don't use block-style-only string literals in flow mode#236
Merged
dervus merged 1 commit intonodeca:masterfrom Jan 10, 2016
Merged
don't use block-style-only string literals in flow mode#236dervus merged 1 commit intonodeca:masterfrom
dervus merged 1 commit intonodeca:masterfrom
Conversation
Contributor
Author
|
btw ... I tried to install eslint but ... $ make lint (I am more familiar with js-hint...) If you need an explicit version, perhaps better to point the |
Contributor
Author
|
(slap-on-head -- test numbering system isn't so complex :)) |
Collaborator
|
Seems good, but could you squish it into single commit? |
Contributor
Author
|
How's that? I think I got the squash right this time. :) |
dervus
added a commit
that referenced
this pull request
Jan 10, 2016
Don't use block-style-only string literals in flow mode
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a fix to #235. I included a test, but I didn't understand your test numbering system.