Improve browserify support#232
Merged
puzrin merged 1 commit intonodeca:masterfrom Dec 18, 2015
ArtskydJ:improve-browserify-support
Merged
Improve browserify support#232puzrin merged 1 commit intonodeca:masterfrom ArtskydJ:improve-browserify-support
puzrin merged 1 commit intonodeca:masterfrom
ArtskydJ:improve-browserify-support
Conversation
Member
|
Thanks! I plan to make release after #228 fixed or in a week. |
|
Would you be willing to release this change as a patch version, and release #228 afterward as a feature/minor version? |
Member
|
I'd prefer to increase minor version for this change too. |
|
Fair enough. |
|
Any chance this could make it to npm? |
Member
|
That does not work well, because replace module with {} instead if ignoring. It became a problem, when you do really need to use esprima. Replaced your commit with 6bdb5e7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230. Supersedes #231.