Skip to content

Add dedup option#229

Merged
puzrin merged 1 commit intonodeca:masterfrom
devongovett:patch-1
Dec 18, 2015
Merged

Add dedup option#229
puzrin merged 1 commit intonodeca:masterfrom
devongovett:patch-1

Conversation

@devongovett
Copy link
Copy Markdown
Contributor

Sometimes I don't want to produce references for duplicated objects. This adds an option to avoid that.

@dervus
Copy link
Copy Markdown
Collaborator

dervus commented Dec 14, 2015

  1. Boolean options must default to false. You should inverse the meaning the of this option.
  2. Do not use comparison operators with booleans.
  3. Fix code styling violations eslint complains about.

UPD: 4. All option fields must be explicitly defined in State object constructor.

@puzrin
Copy link
Copy Markdown
Member

puzrin commented Dec 18, 2015

Any ideas about good reversed name for dedup?

@dervus
Copy link
Copy Markdown
Collaborator

dervus commented Dec 18, 2015

norefs

@puzrin
Copy link
Copy Markdown
Member

puzrin commented Dec 18, 2015

+1

@devongovett
Copy link
Copy Markdown
Contributor Author

Updated.

@puzrin
Copy link
Copy Markdown
Member

puzrin commented Dec 18, 2015

Could you squash all to single commit "Added norefs option to dumper"?

@devongovett
Copy link
Copy Markdown
Contributor Author

Done.

puzrin pushed a commit that referenced this pull request Dec 18, 2015
@puzrin puzrin merged commit 0fbab05 into nodeca:master Dec 18, 2015
@puzrin
Copy link
Copy Markdown
Member

puzrin commented Dec 18, 2015

Thanks!

@devongovett devongovett deleted the patch-1 branch December 18, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants