Skip to content

Bump esprima to v2.6.x#209

Merged
puzrin merged 1 commit intonodeca:masterfrom
shinnn:deps
Oct 10, 2015
Merged

Bump esprima to v2.6.x#209
puzrin merged 1 commit intonodeca:masterfrom
shinnn:deps

Conversation

@shinnn
Copy link
Copy Markdown
Contributor

@shinnn shinnn commented Oct 10, 2015

npm v3 tries to depdupe the dependencies by default, and keeping dependencies up-to-date helps de-duplication.

Comment thread package.json Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puzrin How about using ^ operator instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's switch to ^2.6.0. Seems to be ok. Will you update PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll get right on it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping libraries up-to-date helps dependency de-duplication.
puzrin pushed a commit that referenced this pull request Oct 10, 2015
Bump esprima to v2.6.x
@puzrin puzrin merged commit 026c572 into nodeca:master Oct 10, 2015
@shinnn
Copy link
Copy Markdown
Contributor Author

shinnn commented Oct 10, 2015

@puzrin Thanks. Could you publish a new version?

@puzrin
Copy link
Copy Markdown
Member

puzrin commented Oct 10, 2015

done

@shinnn
Copy link
Copy Markdown
Contributor Author

shinnn commented Oct 10, 2015

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants