fixed broken serialization of duplicated entries in sequences#205
Merged
dervus merged 1 commit intonodeca:masterfrom Sep 9, 2015
Merged
fixed broken serialization of duplicated entries in sequences#205dervus merged 1 commit intonodeca:masterfrom
dervus merged 1 commit intonodeca:masterfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
A mistake. I will fix it. Just a moment...
For example, with the following code
```
var obj = { test: 'canary' };
var array = [ 0, 1 ];
var arrayWithRefs = [ obj, obj, array, array ];
```
`arrayWithRefs` was serialized as
```
- &ref_0test: canary
- *ref0
- &ref_1- 0
- 1
- *ref1
```
which is incorrect.
vogelsgesang
force-pushed
the
fix_duplicate_serialization
branch
from
b83e4f6 to
b157c24
Compare
Contributor
Author
|
Rebased in order to remove the duplicated empty line I introduced. |
Member
|
please remove "make browserify" from PR. |
vogelsgesang
force-pushed
the
fix_duplicate_serialization
branch
from
b157c24 to
f25843d
Compare
Contributor
Author
|
Ok, I removed the "make browserify" commit. Would be perfect if you could browserify the library then, so that I have a commit to which I can point bower. |
Member
|
Browserification is done for every tagged release. I'll release as soon as @dervus confirm that PR is ok. |
dervus
added a commit
that referenced
this pull request
Sep 9, 2015
fixed broken serialization of duplicated entries in sequences
Collaborator
|
@vogelsgesang Thanks for contribution! |
Contributor
Author
|
Thanks for your quick response and for maintaining this library :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the serialization of duplicated values within arrays. For example, with the following code
arrayWithRefswas serialized aswhich is incorrect. Line breaks were missing between the reference names (
ref_0,ref_1) and the consecutive characters.In addition, this PR contains a regression test.