Skip to content

Fixes { "push\npop": env: {} } dumping case.#197

Merged
puzrin merged 2 commits intonodeca:masterfrom
tcr:master
Jul 8, 2015
Merged

Fixes { "push\npop": env: {} } dumping case.#197
puzrin merged 2 commits intonodeca:masterfrom
tcr:master

Conversation

@tcr
Copy link
Copy Markdown
Contributor

@tcr tcr commented Jul 8, 2015

A multiline key as an object key generates invalid YAML. E.g.

yaml.safeDump({"push\npop": {env: {}}})

yields

|-
  push
  pop:
  env: {}

This patch corrects this case, but doesn't add tests, etc. I'm happy to do any work to get it mergeable.

@puzrin
Copy link
Copy Markdown
Member

puzrin commented Jul 8, 2015

@tcr
Copy link
Copy Markdown
Contributor Author

tcr commented Jul 8, 2015

@puzrin Added!

puzrin pushed a commit that referenced this pull request Jul 8, 2015
Fixes { "push\npop": env: {} } dumping case.
@puzrin puzrin merged commit 04f3c1b into nodeca:master Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants