Fixed crash on malformed yaml#157
Closed
grigoryvp wants to merge 1 commit intonodeca:masterfrom
grigoryvp:master
Closed
Fixed crash on malformed yaml#157grigoryvp wants to merge 1 commit intonodeca:masterfrom grigoryvp:master
grigoryvp wants to merge 1 commit intonodeca:masterfrom
grigoryvp:master
Conversation
Following malformed yaml results in crash instead of proper YAMLException: foo: !!int
Member
|
Ups... lately we fixed null e89db06 but seems this bug exists in other resolvers. Your fix looks correct, but at first glance the same bug still stay at least in bool & binary. I thing, it would be better to fix all types at once. Also, it worth adding tests to |
Collaborator
It doesn't conform our coding style. Anyway, don't bother. I'll fix that by myself today. |
Collaborator
|
Fixed in 3.2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following malformed yaml results in crash instead of proper YAMLException:
This provides a simple fix. If you need additional information, tests or anything else - I will be glad to help.