Read from STDIN if data is being piped in#135
Merged
puzrin merged 1 commit intonodeca:masterfrom Jul 26, 2014
Merged
Conversation
Member
|
Did you googled fo "argparse stdin" ? Seems stackoverflow has some answers. |
Contributor
Author
|
The fundamental problem was that |
Member
|
So, why you did not used nargs with default to '-' or something like that ? |
Contributor
Author
|
Check 808373e, which I just attached to this PR. |
Member
|
Please, rebase - squash into one commit |
Contributor
Author
|
Done. |
Member
|
What happens if no file defined, and no data piped via Preliminary looks ok for me |
Contributor
Author
|
It reads from |
Collaborator
There was a problem hiding this comment.
This should be function readFile(...) {
Collaborator
|
Except the remark, it looks good for me. |
Contributor
Author
|
Changed, thanks. |
puzrin
pushed a commit
that referenced
this pull request
Jul 26, 2014
Read from STDIN if data is being piped in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...was a cheeky way of making
fileoptional (I couldn't figure out how to make positional arguments optional withargparse). However, a side-effect of this is that-isn't a valid way to instructjs-yamlto read fromSTDIN. I'm happy to amend the patch if you have suggestions on how to achieve this.(This addresses #130)