Skip to content

[writer] can we remove deprecated boolean strings ? #266

@jeromew

Description

@jeromew

I saw in the dumper that there is an array

var DEPRECATED_BOOLEANS_SYNTAX = [
  'y', 'Y', 'yes', 'Yes', 'YES', 'on', 'On', 'ON',
  'n', 'N', 'no', 'No', 'NO', 'off', 'Off', 'OFF'
];

I was wondering when this deprecation was introduced and if we could remove it altogether. This code adds unwanted quotes around "y" keys for example.

Thanks for your input. I could send a PR removing this.

If you want to keep compatibility ( write a 1.2 file, but read with a 1.0/1.1 reader), maybe it could be possible to add a dump option specifying which version of reader we target.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions