Repository navigation
Commit eb5cb5b
authored
fix: round-trip integers that stringify in exponential notation (#771)
Integers at or above 1e21 (and Number.MAX_VALUE) stringify via
Number.prototype.toString(10) in exponential notation, e.g. 1e21 -> "1e+21".
The int tags identified these numbers (1e21 % 1 === 0) and represented them
with that exponential text, producing output like `!!int '1e+21'`. That text
matches no `!!int` resolution pattern, so loading the library's own dump output
threw "cannot resolve a node with !<tag:yaml.org,2002:int> explicit tag".
Per YAML 1.2.2 the Core (10.3) and JSON (10.2) `!!int` resolution accepts only
[-+]?[0-9]+ (plus 0o/0x forms); exponential text is a float, not an int.
Make the int tags reject numbers whose decimal stringification contains an
exponent, and let the float tags claim them instead. The float `represent`
already emits a valid float form (1.e+21) for such values, so they now
round-trip. Restores the "numbers survive round-trip" invariant (#737) for
large integers across the default, Core, JSON and YAML 1.1 schemas.1 parent 89024c4 commit eb5cb5b
7 files changed
Lines changed: 32 additions & 6 deletions
File tree
- src/tag/scalar
- test/core/tags
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
61 | 64 | | |
62 | 65 | | |
63 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
42 | 53 | | |
43 | 54 | | |
44 | 55 | | |
| |||
0 commit comments