Skip to content

📦 NEW: [BREAKING] Refactor impl base on undici#382

Merged
fengmk2 merged 21 commits intomasterfrom
using-undici
Jul 16, 2022
Merged

📦 NEW: [BREAKING] Refactor impl base on undici#382
fengmk2 merged 21 commits intomasterfrom
using-undici

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Jun 12, 2022

@fengmk2 fengmk2 self-assigned this Jun 12, 2022
@lgtm-com

This comment was marked as outdated.

@codecov

This comment was marked as outdated.

@lgtm-com

This comment was marked as resolved.

Comment thread jest.config.js Outdated
@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Jun 13, 2022

@atian25 没看到效果?

@atian25
Copy link
Copy Markdown
Member

atian25 commented Jun 14, 2022

@atian25 没看到效果?

ts-jest 那个源码有点绕,不知道是不是 ts-jest 的 preset 和 reporters 冲突了。

也有可能是 GitHub Action 问题,可以等下个 PR 再看看。

@socket-security

This comment was marked as resolved.

@lgtm-com

This comment was marked as resolved.

@fengmk2 fengmk2 force-pushed the using-undici branch 2 times, most recently from b6aa94c to 681efbf Compare June 19, 2022 11:23
fengmk2 added a commit to cnpm/npminstall that referenced this pull request Jun 19, 2022
Comment thread test/fixtures/server.ts Fixed
Comment thread test/fixtures/server.ts Fixed
fengmk2 added a commit to cnpm/npminstall that referenced this pull request Jun 25, 2022
Comment thread test/fixtures/server.ts

if (pathname === '/mock-bytes') {
const size = urlObject.searchParams.get('size') ?? '1024';
const bytes = Buffer.alloc(parseInt(size));

Check failure

Code scanning / CodeQL

Resource exhaustion

This creates a buffer with a user-controlled size from [here](1).
Comment thread test/utils.ts

export async function sleep(ms: number) {
await new Promise(resolve => {
setTimeout(resolve, ms);

Check failure

Code scanning / CodeQL

Resource exhaustion

This creates a timer with a user-controlled duration from [here](1).
@fengmk2 fengmk2 changed the title [WIP] 📦 NEW: [BREAKING] Refactor impl base on undici 📦 NEW: [BREAKING] Refactor impl base on undici Jun 26, 2022
@fengmk2 fengmk2 force-pushed the using-undici branch 2 times, most recently from 7600289 to de8ab5b Compare July 3, 2022 08:24
@fengmk2 fengmk2 merged commit a8ef220 into master Jul 16, 2022
@fengmk2 fengmk2 deleted the using-undici branch July 16, 2022 15:02
@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Jul 16, 2022

3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Better http lib: undici

3 participants