fix: make sure only one logger instance in global (#2)

fengmk2 · web-flow · commit f8c8d18f1d50 · 2025-01-01T15:03:17.000+08:00
&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;
## Summary by CodeRabbit

## Release Notes

- **CI/CD Improvements**
  - Added support for Node.js version 22 in CI workflows
- Introduced new automated publishing workflow for commits and pull
requests

- **Dependencies**
  - Updated development dependencies
  - Added type checking CLI tool
  - Updated Node.js type definitions

- **Project Configuration**
  - Added ES module entry point
  - Enhanced pre-publish script with additional type checking

- **Documentation**
  - Updated README with Node.js version badge
  - Refreshed contributors section with a new badge
&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -3,7 +3,6 @@ name: CI
 on:
   push:
     branches: [ master ]
-
   pull_request:
     branches: [ master ]
 
@@ -13,4 +12,6 @@ jobs:
     uses: node-modules/github-actions/.github/workflows/node-test.yml@master
     with:
       os: 'ubuntu-latest, macos-latest, windows-latest'
-      version: '16, 18, 20'
+      version: '16, 18, 20, 22'
+    secrets:
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/pkg.pr.new.yml b/.github/workflows/pkg.pr.new.yml
@@ -0,0 +1,23 @@
+name: Publish Any Commit
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - run: corepack enable
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Build
+        run: npm run prepublishOnly --if-present
+
+      - run: npx pkg-pr-new publish
diff --git a/README.md b/README.md
@@ -5,6 +5,7 @@
 [![Test coverage][codecov-image]][codecov-url]
 [![Known Vulnerabilities][snyk-image]][snyk-url]
 [![npm download][download-image]][download-url]
+[![Node.js Version](https://img.shields.io/node/v/onelogger.svg?style=flat)](https://nodejs.org/en/download/)
 
 [npm-image]: https://img.shields.io/npm/v/onelogger.svg?style=flat-square
 [npm-url]: https://npmjs.org/package/onelogger
@@ -66,16 +67,8 @@ getCustomLogger('myBizLogger');
 
 ## License
 
-[MIT](LICENSE.txt)
-
-<!-- GITCONTRIBUTOR_START -->
+[MIT](LICENSE)
 
 ## Contributors
 
-|[<img src="https://avatars.githubusercontent.com/u/156269?v=4" width="100px;"/><br/><sub><b>fengmk2</b></sub>](https://github.com/fengmk2)<br/>|
-| :---: |
-
-
-This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Sat Jan 20 2024 22:39:14 GMT+0800`.
-
-<!-- GITCONTRIBUTOR_END -->
+[![contributors](https://contrib.rocks/image?repo=node-modules/onelogger&max=240&columns=26)](https://github.com/node-modules/onelogger/graphs/contributors)
diff --git a/package.json b/package.json
@@ -4,14 +4,14 @@
   "description": "the only ONE logger",
   "dependencies": {},
   "devDependencies": {
+    "@arethetypeswrong/cli": "^0.17.2",
     "@eggjs/tsconfig": "^1.3.3",
     "@types/mocha": "^10.0.1",
-    "@types/node": "^20.6.3",
-    "git-contributor": "*",
+    "@types/node": "22",
     "egg-bin": "^6.5.2",
     "eslint": "^8.49.0",
     "eslint-config-egg": "^13.0.0",
-    "tshy": "^1.1.1",
+    "tshy": "^3.0.2",
     "tshy-after": "^1.0.0",
     "typescript": "^5.2.2"
   },
@@ -24,10 +24,9 @@
     "test": "npm run test-local",
     "test-local": "egg-bin test",
     "cov": "egg-bin cov",
-    "preci": "npm run prepublishOnly",
+    "preci": "npm run prepublishOnly && attw --pack",
     "ci": "npm run lint && npm run cov",
-    "prepublishOnly": "tshy && tshy-after",
-    "contributor": "git-contributor"
+    "prepublishOnly": "tshy && tshy-after"
   },
   "repository": {
     "type": "git",
@@ -69,5 +68,6 @@
     }
   },
   "types": "./dist/commonjs/index.d.ts",
-  "main": "./dist/commonjs/index.js"
+  "main": "./dist/commonjs/index.js",
+  "module": "./dist/esm/index.js"
 }
diff --git a/src/Logger.ts b/src/Logger.ts
@@ -7,7 +7,10 @@ declare global {
   var __ONE_LOGGER_INSTANCES__: Map<string, ILogger>;
 }
 
-globalThis.__ONE_LOGGER_INSTANCES__ = new Map<string, ILogger>();
+// make sure we have a global logger instances map
+if (!globalThis.__ONE_LOGGER_INSTANCES__) {
+  globalThis.__ONE_LOGGER_INSTANCES__ = new Map<string, ILogger>();
+}
 
 export interface LoggerOptions {
   loggerName: string;
