fix: make sure mocks as global variable for multiple versions of muk-prop (#4)

fengmk2 · web-flow · commit 62e120b304bd · 2024-12-22T11:51:52.000+08:00
&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;

## Summary by CodeRabbit

- **New Features**
- Introduced a global mechanism for managing mock items, improving
accessibility across module systems.
	- Added a new function to retrieve and manage mock items globally.

- **Bug Fixes**
- Enhanced the mock restoration process for better efficiency and
reliability.

&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/src/index.ts b/src/index.ts
@@ -6,7 +6,15 @@ export interface MockItem {
   hasOwnProperty: boolean;
 }
 
-let mocks: MockItem[] = [];
+const MOCKS = Symbol.for('@cnpmjs/muk-prop mocks');
+// make sure mocks is a global variable for multiple versions of muk-prop
+// in the same process, e.g.: CommonJS and ES module
+function getMocks() {
+  if (!Reflect.has(globalThis, MOCKS)) {
+    Reflect.set(globalThis, MOCKS, []);
+  }
+  return Reflect.get(globalThis, MOCKS) as MockItem[];
+}
 
 const cache = new Map<any, Set<any>>();
 
@@ -15,7 +23,7 @@ const cache = new Map<any, Set<any>>();
  */
 export function mock(obj: any, key: PropertyKey, value?: any) {
   const hasOwnProperty = Object.hasOwn(obj, key);
-  mocks.push({
+  getMocks().push({
     obj,
     key,
     descriptor: Object.getOwnPropertyDescriptor(obj, key)!,
@@ -61,8 +69,9 @@ export const muk = mock;
  * Restore all mocks
  */
 export function restore() {
-  for (let i = mocks.length - 1; i >= 0; i--) {
-    const m = mocks[i];
+  const mocks = getMocks();
+  while (mocks.length) {
+    const m = mocks.pop()!;
     if (!m.hasOwnProperty) {
       // Delete the mock key, use key on the prototype
       delete m.obj[m.key];
@@ -71,7 +80,6 @@ export function restore() {
       Object.defineProperty(m.obj, m.key, m.descriptor);
     }
   }
-  mocks = [];
   cache.clear();
 }
 
