Skip to content

Conversation

@cclauss
Copy link

@cclauss cclauss commented Jul 14, 2023

On the node-gyp repo, we have a lot of ffi-napi issues so let's test this software on modern versions of Node.js to see if those issues can be replicated in CI.

-    - nodejs_version: "10"
-    - nodejs_version: "12"
-    - nodejs_version: "14"
+    - nodejs_version: "16"
+    - nodejs_version: "18"
+    - nodejs_version: "20"

Screenshot 2023-07-14 at 07 19 25

  Callback
    √ should create a C function pointer from a JS function
    √ should be invokable by an ffi'd ForeignFunction (119ms)
    √ should work with a "void" return type (113ms)
    √ should not call "set()" of a pointer type (117ms)
    √ should throw an Error when invoked through a ForeignFunction and throws (130ms)
    √ should throw an Error with a meaningful message when a type's "set()" throws (88ms)
    - should throw an Error when invoked after the callback gets garbage collected
    √ should propagate callbacks and errors back from native threads (175ms)
    async
      √ should be invokable asynchronously by an ffi'd ForeignFunction (125ms)
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------
Command exited with code -1073741819

@addaleax @xingrz

@cclauss
Copy link
Author

cclauss commented Mar 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant