Migrate to GitHub Actions#199
Open
xingrz wants to merge 3 commits intonode-ffi-napi:masterfrom
Open
Conversation
xingrz
force-pushed
the
migrate-github-actions
branch
2 times, most recently
from
f953c5f to
d55d9be
Compare
xingrz
force-pushed
the
migrate-github-actions
branch
from
d55d9be to
ebf1dd4
Compare
|
any process? |
cclauss
suggested changes
Jul 14, 2023
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v3 |
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-python@v2 | |
| uses: actions/setup-python@v4 |
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.9 |
There was a problem hiding this comment.
Suggested change
| python-version: 3.9 | |
| python-version: 3.x |
| - uses: actions/setup-node@v2 | ||
|
|
||
| - name: Set up Node.js LTS | ||
| uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-node@v2 | |
| uses: actions/setup-node@v3 |
| run: npm run prebuild | ||
|
|
||
| - name: Upload artifacts for ${{ matrix.os }} | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@v2 | |
| uses: actions/upload-artifact@v3 |
| npm install node-gyp@latest | ||
|
|
||
| - name: Download prebuilt artifacts | ||
| uses: actions/download-artifact@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/download-artifact@v2 | |
| uses: actions/download-artifact@v3 |
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v3 |
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-node@v2 | |
| uses: actions/setup-node@v3 |
| cache: 'npm' | ||
|
|
||
| - name: Download prebuilt artifacts | ||
| uses: actions/download-artifact@v2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/download-artifact@v2 | |
| uses: actions/download-artifact@v3 |
| node-version: ${{ matrix.node }} | ||
| cache: 'npm' | ||
|
|
||
| - name: Update node-gyp for Node.js <= 14 on Windows |
There was a problem hiding this comment.
This is no longer needed because v14 is end-of-life.
Closed
cclauss
approved these changes
Jul 14, 2023
|
A gentle nudge on this, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new workflow:
windows-latest,linux-latestanddarwin-latestplatformsv*, publish it to NPMWhat need to do to make this migration works:
https://www.npmjs.com/settings/<yourname>/tokenswith at least aPublishpermissionNPM_TOKENon https://github.com/node-ffi-napi/node-ffi-napi/settings/secrets/actions with the token just created.Here's how to publish a new version:
npm version 4.0.4 # npm will create a git tag v4.0.4 automatically git push origin master --tags