workaround of Callback is garbage collected#391
Open
king6cong wants to merge 1 commit intonode-ffi:masterfrom
Open
workaround of Callback is garbage collected#391king6cong wants to merge 1 commit intonode-ffi:masterfrom
Callback is garbage collected#391king6cong wants to merge 1 commit intonode-ffi:masterfrom
Conversation
addaleax
pushed a commit
to node-ffi-napi/node-ffi
that referenced
this pull request
Nov 27, 2017
|
Hi @king6cong , I know I come on this thread kind of late, but did you try to fix the tests as well ? I've been working on node-ffi lately, I managed to make node-ffi work with >= node 10 (mainly for a player I'm developing in Electron 3) and also got rid of all the deprecation warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#241