Open
Conversation
content-encoding should not have been normalized
gr2m
reviewed
Jan 27, 2022
Collaborator
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
getAll()&raw()and all of the URLSearchParams methods are removed
Make sure to add BREAKING CHANGE: statements in the commit body when you merge. You can add multiple, e.g.
refactor: replace headers class for better compatibility with the spec
BREAKING CHANGE: `Headers.getAll()` has been removed
BREAKING CHANGE: `Headers.raw()` has been removed
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the header class for something that follows the spec a little more correctly
Changes
getAll()&raw()and all of the URLSearchParams methods are removedAdditional information
fetch-headerspackage has it's own test that are run against WPT - but i tough of keeping them for now just to make sure things still works.(
content-encodingshould be case case insensitive and not normalized - so this is now being done in the fetch method now instead)