backport of #1449 #1453
Merged
backport of #1449 #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekwiz
approved these changes
Jan 15, 2022
|
@jimmywarting Not sure if it's on your turf, but Snyk still shows v2.6.7 as vulnerable. https://snyk.io/test/npm/node-fetch/2.6.7?tab=issues |
They changed it now. Disregard 😄 |
|
grate, i was going to lookin to comfirm with it yesterday but got tied up with other work and it was getting late. glad they changed it. |
|
@jimmywarting FYI GitHub Advisory Database is still showing any version <3.1.1 as vulnerable including this backport so npm audit is flagging it. GHSA-r683-j2x4-v87g Is there anything that can be done from your end about this? |
|
not sure what to do actually... it's fixed already. |
I ran into the same issue with a package I maintain not that long ago. I had to ping GitHub/npm staff to fix it. (They apparently have a feature in the works to allow folks to suggest updates but it's not rolled out yet.) |
|
|
@jimmywarting You'll also want to update https://nvd.nist.gov/vuln/detail/CVE-2022-0235. For that, email [email protected]. |
|
Looks like https://nvd.nist.gov/vuln/detail/CVE-2022-0235 was updated to include 2.6.7! |
This was referenced Jan 31, 2022
P0lip
pushed a commit
to crudo/spectral
that referenced
this pull request
Jan 31, 2022
otc-zuul bot
pushed a commit
to opentelekomcloud/ui-cluster-driver-otc
that referenced
this pull request
Mar 29, 2022
Bump node-fetch from 2.6.1 to 2.6.7 Bumps node-fetch from 2.6.1 to 2.6.7. Release notes Sourced from node-fetch's releases. v2.6.7 Security patch release Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred What's Changed fix: don't forward secure headers to 3th party by @jimmywarting in node-fetch/node-fetch#1453 Full Changelog: node-fetch/[email protected] v2.6.6 What's Changed fix(URL): prefer built in URL version when available and fallback to whatwg by @jimmywarting in node-fetch/node-fetch#1352 Full Changelog: node-fetch/[email protected] v2.6.2 fixed main path in package.json Commits 1ef4b56 backport of #1449 (#1453) 8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310) f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (... b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303) 18193c5 fix v2.6.3 that did not sending query params (#1301) ace7536 fix: properly encode url with unicode characters (#1291) 152214c Fix(package.json): Corrected main file path in package.json (#1274) See full diff in compare view Maintainer changes This version was pushed to npm by endless, a new releaser for node-fetch since your current version. Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) @dependabot use these labels will set the current labels as the default for future PRs for this repo and language @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the Security Alerts page. Reviewed-by: Anton Kachurin <[email protected]>
otc-zuul bot
pushed a commit
to opentelekomcloud/ui-driver-otc
that referenced
this pull request
Apr 12, 2022
Bump node-fetch from 2.6.1 to 2.6.7 Bumps node-fetch from 2.6.1 to 2.6.7. Release notes Sourced from node-fetch's releases. v2.6.7 Security patch release Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred What's Changed fix: don't forward secure headers to 3th party by @jimmywarting in node-fetch/node-fetch#1453 Full Changelog: node-fetch/[email protected] v2.6.6 What's Changed fix(URL): prefer built in URL version when available and fallback to whatwg by @jimmywarting in node-fetch/node-fetch#1352 Full Changelog: node-fetch/[email protected] v2.6.2 fixed main path in package.json Commits 1ef4b56 backport of #1449 (#1453) 8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310) f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (... b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303) 18193c5 fix v2.6.3 that did not sending query params (#1301) ace7536 fix: properly encode url with unicode characters (#1291) 152214c Fix(package.json): Corrected main file path in package.json (#1274) See full diff in compare view Maintainer changes This version was pushed to npm by endless, a new releaser for node-fetch since your current version. Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) @dependabot use these labels will set the current labels as the default for future PRs for this repo and language @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the Security Alerts page. Reviewed-by: Anton Kachurin <[email protected]>
This was referenced May 5, 2022
This was referenced Jun 25, 2022
|
🎉 This PR is included in version 2.6.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
backport of #1449 as a bug/security fix