fix(URL): prefer built in URL version when available and fallback to whatwg (#1352)

jimmywarting · web-flow · commit f56b0c66d3dd · 2021-10-31T16:40:17.000+01:00
* fix(URL): prefer built in URL version when available and fallback to whatwg

* bump minor
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "node-fetch",
-    "version": "2.6.5",
+    "version": "2.6.6",
     "description": "A light-weight module that brings window.fetch to node.js",
     "main": "lib/index.js",
     "browser": "./browser.js",
diff --git a/src/request.js b/src/request.js
@@ -14,7 +14,7 @@ import Headers, { exportNodeCompatibleHeaders } from './headers.js';
 import Body, { clone, extractContentType, getTotalBytes } from './body';
 
 const INTERNALS = Symbol('Request internals');
-const URL = whatwgUrl.URL;
+const URL = Url.URL || whatwgUrl.URL;
 
 // fix an issue where "format", "parse" aren't a named export for node <10
 const parse_url = Url.parse;
diff --git a/test/test.js b/test/test.js
@@ -2875,4 +2875,11 @@ describe('issue #1290', function() {
 			});
 		});
 	});
+
+	// #1342
+	it('should not throw with a valid URL', () => {
+		const url = 'https://r2---sn-n4v7sney.example.com';
+		new Request(url);
+	});
+
 });

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "node-fetch",`
`3`		`- "version": "2.6.5",`
	`3`	`+ "version": "2.6.6",`
`4`	`4`	`"description": "A light-weight module that brings window.fetch to node.js",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"browser": "./browser.js",`