fix v2.6.3 that did not sending query params (#1301)

jimmywarting · web-flow · commit 18193c5922c6 · 2021-09-21T16:42:50.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ Changelog
 
 # 2.x release
 
+## v2.6.4
+
+- Hotfix: fix v2.6.3 that did not sending query params
+
 ## v2.6.3
 
 - Fix: properly encode url with unicode characters
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "node-fetch",
-    "version": "2.6.3",
+    "version": "2.6.4",
     "description": "A light-weight module that brings window.fetch to node.js",
     "main": "lib/index.js",
     "browser": "./browser.js",
diff --git a/src/request.js b/src/request.js
@@ -33,19 +33,7 @@ function parseURL(urlStr) {
 		Absolute URL: https://tools.ietf.org/html/rfc3986#section-4.3
 	*/
 	if (/^[a-zA-Z][a-zA-Z\d+\-.]*:/.exec(urlStr)) {
-		const url = new URL(urlStr);
-
-		return {
-			path: url.pathname,
-			pathname: url.pathname,
-			hostname: url.hostname,
-			protocol: url.protocol,
-			port: url.port,
-			hash: url.hash,
-			search: url.search,
-			query: url.query,
-			href: url.href,
-		}
+		urlStr = new URL(urlStr).toString()
 	}
 
 	// Fallback to old implementation for arbitrary URLs
diff --git a/test/test.js b/test/test.js
@@ -2847,6 +2847,15 @@ describe('external encoding', () => {
 });
 
 describe('issue #1290', function() {
+
+	it('should keep query params', function() {
+		return fetch(`${base}inspect?month=2021-09`)
+		  .then(res => res.json())
+			.then(json => {
+				expect(json.url).to.equal('/inspect?month=2021-09')
+			})
+	})
+
 	it('should handle escaped unicode in URLs', () => {
 		const url = `${base}issues/1290/%E3%81%B2%E3%82%89%E3%81%8C%E3%81%AA`;
 		return fetch(url).then((res) => {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "node-fetch",`
`3`		`- "version": "2.6.3",`
	`3`	`+ "version": "2.6.4",`
`4`	`4`	`"description": "A light-weight module that brings window.fetch to node.js",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"browser": "./browser.js",`