test/19-custom-environment-variables.js (1)

7-9: Switch to Load is reasonable; consider per-test instantiation to avoid hidden state

Load.loadFile merges into the loader’s state via addConfig. Reusing a single LOAD across tests can accumulate state and subtly affect later expectations. Prefer creating a fresh loader in each beforeEach where you need to parse a file.

test/7-unicode-situations.js (3)

7-12: Good migration to Load; consider isolating loader instances per test

Load accumulates config via addConfig. Creating a new Load({}) inside each test (or beforeEach) helps avoid cross-test pollution if additional files are loaded in future assertions.

---

16-21: Prefer path.join and consider asserting the parsed result is non-null

Using path.join is more robust than string concatenation with path.sep.

-      let standardNoBomConfigFile = process.env.NODE_CONFIG_DIR + path.sep + 'defaultNoBOM.json';
+      const standardNoBomConfigFile = path.join(process.env.NODE_CONFIG_DIR, 'defaultNoBOM.json');
       assert.doesNotThrow(function () {
         result = LOAD.loadFile(standardNoBomConfigFile);
       }, 'standard config file with no BOM has a parse error');
+      assert.ok(result && typeof result === 'object', 'Parsed config should be an object');

---

25-31: Same here: build the path with path.join and assert the parse output

-      let configFileWithBom = process.env.NODE_CONFIG_DIR + path.sep + 'defaultWithUnicodeBOM.json';
+      const configFileWithBom = path.join(process.env.NODE_CONFIG_DIR, 'defaultWithUnicodeBOM.json');
       assert.doesNotThrow(function () {
         result = LOAD.loadFile(configFileWithBom);
       }, 'config file with BOM has a parse error');
+      assert.ok(result && typeof result === 'object', 'Parsed config should be an object');

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

test/19-custom-environment-variables.js (1)

7-9: Prefer per-call Load construction and OS-safe path joins; avoid misleading ALL_CAPS instance

• Load keeps internal state (config/sources). Reusing a single global instance across test cases can accumulate state and lead to brittle tests if more files are loaded later. Instantiating per call is cheap and avoids hidden coupling.
• Split Path.join arguments into separate segments for better cross-platform behavior.
• Minor: Use a standard relative require and avoid ALL_CAPS for an instance.

Apply this diff:

-const { Load } = require(__dirname + '/../lib/util');
+const { Load } = require('../lib/util');

-const LOAD = new Load({});
 
-configObject = LOAD.loadFile(Path.join(__dirname, '19-config/default.js'));
+configObject = new Load({}).loadFile(Path.join(__dirname, '19-config', 'default.js'));

-configObject = LOAD.loadFile(Path.join(__dirname, '19-config/default.js'));
+configObject = new Load({}).loadFile(Path.join(__dirname, '19-config', 'default.js'));

Also applies to: 23-23, 43-43

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.