Conversation
gr2m
approved these changes
Mar 27, 2025
Member
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
I confirmed that the test is failing without the fix.
No biggi, but something I find very helpful for reviewers is to push the test first as a commit to show that it's failing, and then push the commits that implement the fix or feature to show that the new tests are now passing
|
|
||
| beforeEach(() => { | ||
| // random fixture file so tests don't interfere with each other | ||
| const token = crypto.randomBytes(4).toString('hex') |
Member
There was a problem hiding this comment.
instead of random bytes, can we use a global counter that gets incremented for each test?
|
🎉 This PR is included in version 14.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2841