Skip to content

fix(types): return type of BackOptions.afterRecord#2782

Merged
mikicho merged 1 commit intonock:mainfrom
jrnail23:master
Sep 14, 2024
Merged

fix(types): return type of BackOptions.afterRecord#2782
mikicho merged 1 commit intonock:mainfrom
jrnail23:master

Conversation

@jrnail23
Copy link
Copy Markdown
Contributor

This PR fixes a TypeScript discrepancy where the docs (and source code) say nock back's afterRecord function may also return a string, but the typings only allow for Definition[].

@mikicho mikicho changed the title Fix return type of BackOptions.afterRecord fix(types): return type of BackOptions.afterRecord Sep 14, 2024
@mikicho mikicho merged commit fc90bd3 into nock:main Sep 14, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2024

🎉 This PR is included in version 13.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 14.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants