fix(socket): add encrypted attribute for secure requests (#2149)

mastermatt · web-flow · commit 8de6b69247d8 · 2021-02-24T18:53:24.000-07:00
https://nodejs.org/docs/latest/api/tls.html#tls_tlssocket_encrypted https://github.com/nodejs/node/blob/295e766c2782d6d83e33004f7c2204c0a8d52655/lib/_tls_wrap.js#L507-L509
diff --git a/lib/socket.js b/lib/socket.js
@@ -7,9 +7,12 @@ module.exports = class Socket extends EventEmitter {
   constructor(options) {
     super()
 
+    // Pretend this is a TLSSocket
     if (options.proto === 'https') {
       // https://github.com/nock/nock/issues/158
       this.authorized = true
+      // https://github.com/nock/nock/issues/2147
+      this.encrypted = true
     }
 
     this.bufferSize = 0
diff --git a/tests/test_socket.js b/tests/test_socket.js
@@ -1,10 +1,32 @@
 'use strict'
 
+const { expect } = require('chai')
 const http = require('http')
+const https = require('https')
 const nock = require('..')
 
 require('./setup')
 
+it('should expose TLSSocket attributes for HTTPS requests', done => {
+  nock('https://example.test').get('/').reply()
+
+  https.get('https://example.test').on('socket', socket => {
+    expect(socket.authorized).to.equal(true)
+    expect(socket.encrypted).to.equal(true)
+    done()
+  })
+})
+
+it('should not have TLSSocket attributes for HTTP requests', done => {
+  nock('http://example.test').get('/').reply()
+
+  http.get('http://example.test').on('socket', socket => {
+    expect(socket.authorized).to.equal(undefined)
+    expect(socket.encrypted).to.equal(undefined)
+    done()
+  })
+})
+
 describe('`Socket#setTimeout()`', () => {
   it('adds callback as a one-time listener for parity with a real socket', done => {
     nock('http://example.test').get('/').delayConnection(100).reply()
