fix: remove duplicates from activeMocks() and pendingMocks() (#2356)

mbargiel · web-flow · commit 7e957b38fbc7 · 2024-02-17T10:17:33.000-08:00
diff --git a/lib/intercept.js b/lib/intercept.js
@@ -350,7 +350,8 @@ function interceptorScopes() {
   const nestedInterceptors = Object.values(allInterceptors).map(
     i => i.interceptors,
   )
-  return [].concat(...nestedInterceptors).map(i => i.scope)
+  const scopes = new Set([].concat(...nestedInterceptors).map(i => i.scope))
+  return [...scopes]
 }
 
 function isDone() {
diff --git a/tests/got/test_nock_lifecycle.js b/tests/got/test_nock_lifecycle.js
@@ -163,6 +163,22 @@ describe('Nock lifecycle functions', () => {
       await got('http://example.test/')
       expect(nock.activeMocks()).to.be.empty()
     })
+
+    it("activeMocks doesn't return duplicate mocks", () => {
+      nock('http://example.test')
+        .get('/')
+        .reply()
+        .get('/second')
+        .reply()
+        .get('/third')
+        .reply()
+
+      expect(nock.activeMocks()).to.deep.equal([
+        'GET http://example.test:80/',
+        'GET http://example.test:80/second',
+        'GET http://example.test:80/third',
+      ])
+    })
   })
 
   describe('resetting nock catastrophically while a request is in progress', () => {

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,8 @@ function interceptorScopes() {`
`350`	`350`	`const nestedInterceptors = Object.values(allInterceptors).map(`
`351`	`351`	`i => i.interceptors,`
`352`	`352`	`)`
`353`		`- return [].concat(...nestedInterceptors).map(i => i.scope)`
	`353`	`+ const scopes = new Set([].concat(...nestedInterceptors).map(i => i.scope))`
	`354`	`+ return [...scopes]`
`354`	`355`	`}`
`355`	`356`
`356`	`357`	`function isDone() {`