feat: add client timeout configuration hint - #519
Merged
Conversation
Update the timeout hint example and relocate the end-to-end test to the get command suite.
Use partial stderr matching and update the example timeout value in the expected output.
Use context state and wrapped deadline errors to distinguish client timeouts from caller deadlines, with coverage for related error cases.
bdw-nobl9
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Client-side timeout errors currently do not tell users that the timeout is configurable, leaving them without an actionable recovery path.
Summary
Added a targeted hint for client timeout failures that directs users to the active context's
timeoutsetting orSLOCTL_TIMEOUT. Preserved the original command error and avoided showing the hint for unrelated timeout failures.Testing
SLOCTL_TIMEOUT=10nsand verifies the exact timeout configuration hint.Release Notes
Added guidance for increasing sloctl's configurable timeout when a request exceeds the client-side timeout.