Remove libandroidfw: it was never used#149
Merged
anatol merged 1 commit intonmeum:masterfrom Jun 18, 2024
Merged
Conversation
I actually cannot find any traces of it *ever* being used but it certainly isn't used now. It builds a bunch of code for a static library that is never consumed, which is both slow and also potentially erroring out (since the unused code contains strict-aliasing violations). Fixes: nmeum#148
anatol
requested changes
Jun 18, 2024
Contributor
Author
|
CI failure is the return of the terrible horrible no good very bad GitHub Actions Python... |
anatol
approved these changes
Jun 18, 2024
Collaborator
|
thank you @eli-schwartz for your contribution! |
Contributor
Author
|
I actually realized I should have deleted the patches/base/ as well, and pushed an amended commit approximately 90 seconds after you merged the PR. :D |
Collaborator
np, please send another PR. |
Contributor
Author
Collaborator
|
There are some leftovers that can be removed. I shall create a pull request with those change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I actually cannot find any traces of it ever being used but it certainly isn't used now. It builds a bunch of code for a static library that is never consumed, which is both slow and also potentially erroring out (since the unused code contains strict-aliasing violations).
Fixes: #148