Import <algorithm> to build on GCC 14#129
Conversation
|
LGTM. @csfore could you please also send these changes to upstream Android team? |
|
Also, do you have a link to a compilation report done with GCC 14 (some CI maybe) that shows the failure? |
|
I sent the patches up a couple of couple of days ago 🙂 https://android-review.googlesource.com/c/platform/system/core/+/2839495 And for the build error, would attaching the output of |
|
Here are the build logs for each of them |
|
Thank you for your work @csfore |
|
Thank you! Hopefully it's merged upstream soon enough |
|
@anatol Hello! Those two patches I sent upstream were merged finally (first one was a couple of days ago but wanted to wait for both before I reached out), I'm not entirely sure how you update the project but just wanted to let you know! |
|
Thank you for handling the upstreaming process! First upstream needs to make a new release with these patches. Then |
<algorithm> is no longer included by default in GCC 14 so explicitly including it is now required. Upstream: nmeum/android-tools#129 AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578 AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495 Both CRs to AOSP have been merged and upstream has merged the PR as well, all that is needed is a version bump from AOSP. Closes: https://bugs.gentoo.org/916788 Signed-off-by: Christopher Fore <[email protected]>
<algorithm> is no longer included by default in GCC 14 so explicitly including it is now required. Upstream: nmeum/android-tools#129 AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578 AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495 Both CRs to AOSP have been merged and upstream has merged the PR as well, all that is needed is a version bump from AOSP. Closes: https://bugs.gentoo.org/916788 Signed-off-by: Christopher Fore <[email protected]>
<algorithm> is no longer included by default in GCC 14 so explicitly including it is now required. Upstream: nmeum/android-tools#129 AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578 AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495 Both CRs to AOSP have been merged and upstream has merged the PR as well, all that is needed is a version bump from AOSP. Closes: https://bugs.gentoo.org/916788 Signed-off-by: Christopher Fore <[email protected]> Closes: #34201 Signed-off-by: Zac Medico <[email protected]>
Would it be possible to request a new tag in upstream aosp? platform tools version 34.0.5 was released in October 20231. Footnotes |
|
I too need this update please 🙏. |
4 participants
By default GCC 14 no longer includes , so it has to be explicitly imported now.