vendor/extras: Fix building with newer protobuf versions#120
Merged
Biswa96 merged 2 commits intonmeum:masterfrom Jul 7, 2023
Merged
vendor/extras: Fix building with newer protobuf versions#120Biswa96 merged 2 commits intonmeum:masterfrom
Biswa96 merged 2 commits intonmeum:masterfrom
Conversation
Contributor
|
So the whole locally tested patch looks like this: Tested in openSUSE Tumbleweed with protobuf 21.12 (old) and 22.5 (new). |
This fixes the following linking errors vendor/libliblpdump.a(dynamic_partitions_device_info.pb.cc.o): undefined reference to symbol '_ZN4absl12lts_2023012512log_internal21CheckOpMessageBuilder7ForVar2Ev' /usr/lib/libabsl_log_internal_check_op.so.2301.0.0: error adding symbols: DSO missing from command line The find_package was called twice because protobuf-config.cmake file was not present in versions older than 22.0. Also the Config mode is required to get the private abseil-cpp libraries.
anatol
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119