Skip to content

Trust system certificates for share uploads#89

Merged
cpojer merged 1 commit into
nkzw-tech:mainfrom
dknecht:fix/share-system-certificates
Jun 21, 2026
Merged

Trust system certificates for share uploads#89
cpojer merged 1 commit into
nkzw-tech:mainfrom
dknecht:fix/share-system-certificates

Conversation

@dknecht

@dknecht dknecht commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a Node/Electron TLS helper that merges default, NODE_EXTRA_CA_CERTS, and system certificate stores
  • use it before Codiff share upload fetches and include targeted diagnostics for certificate-chain failures
  • add focused tests for certificate merging, retry behavior, upload ordering, and TLS diagnostics

Validation

  • pnpm exec vp check --fix
  • pnpm exec vp build
  • pnpm exec vp test electron/tests/system-certificates.test.ts electron/tests/shared-walkthrough-upload.test.ts

@cpojer cpojer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer
cpojer merged commit 968097e into nkzw-tech:main Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants