src/runtime/internal/route-rules.ts (1)

93-96: Consider trimming the new explanatory comment block.

These lines mostly restate behavior already captured by RouteRuleOrder and test coverage.

As per coding guidelines "Do not add comments explaining what the line does unless prompted."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/runtime/internal/route-rules.ts` around lines 93 - 96, Remove or shorten
the explanatory comment block above RouteRuleOrder in route-rules.ts so it
doesn't restate behavior already captured by the enum and tests; keep only a
concise one-line note (if any) that clarifies the ordering intent (e.g.,
"Execution order for route rule middleware; lower runs first") and remove the
extra sentence about basicAuth ordering since that logic is enforced by
RouteRuleOrder and covered by tests (refer to the RouteRuleOrder symbol to
locate the code).

src/types/route-rules.ts (1)

37-40: MatchedRouteRule.order is currently dead API surface.

getRouteRules() in src/runtime/internal/app.ts orders middleware via RouteRuleOrder[rule.name] and never consults this field, so type/API and runtime behavior can diverge. Consider removing order for now or wiring it into the comparator.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/types/route-rules.ts` around lines 37 - 40, MatchedRouteRule.order is
unused at runtime; update getRouteRules in src/runtime/internal/app.ts to
consult MatchedRouteRule.order when sorting instead of only using
RouteRuleOrder[rule.name]. Change the comparator in getRouteRules to compute
each rule's sort key as (rule.order ?? RouteRuleOrder[rule.name] ?? 0) so
explicit per-rule order overrides the lookup, and leave the type
MatchedRouteRule.order in src/types/route-rules.ts as-is; ensure comparison
remains stable for equal keys.

src/runtime/internal/route-rules.ts (1)

86-87: Remove the explanatory inline comment block.

The added comment explains behavior rather than encoding intent in code/tests, which conflicts with this repo’s style rule.

As per coding guidelines src/**/*.{ts,js}: “Do not add comments explaining what the line does unless prompted”.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/runtime/internal/route-rules.ts` around lines 86 - 87, Remove the
explanatory inline comment block that begins "// Must run before
`redirect`/`proxy`/`cache`..." in route-rules.ts; instead encode the behavior
via tests or explicit code assertions (e.g., add a unit/integration test or an
ordering constant) so intent is enforced in code, not explained by a comment.
Locate the comment near the routing rules/middleware ordering setup in
route-rules.ts (the section that references redirect/proxy/cache) and delete it,
and if needed add a test or an ordering constant to ensure unauthorized requests
are processed before redirect/proxy/cache.