Reviewing files that changed from the base of the PR and between 5caca6c and 7753975.

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

• src/presets/vercel/runtime/consts.ts (1 hunks)
• src/presets/vercel/runtime/vercel.ts (1 hunks)
• src/presets/vercel/utils.ts (4 hunks)
• test/presets/vercel.test.ts (2 hunks)

src/presets/vercel/runtime/consts.ts (1)

1-1: LGTM! Centralized constant for ISR parameter.

The constant effectively standardizes the ISR URL parameter across the codebase, replacing hardcoded strings and improving maintainability.

src/presets/vercel/utils.ts (4)

14-14: LGTM! Import of centralized ISR parameter constant.

---

237-239: LGTM! Consistent use of ISR_URL_PARAM in route configuration.

The named capture group and destination query string correctly reference the centralized constant.

---

246-264: LGTM! ISR route handling uses centralized constant.

The routing logic properly applies ISR_URL_PARAM across both source patterns and destination URLs for ISR-enabled and ISR-disabled routes.

---

475-480: Guard against undefined allowQuery before calling .includes().

The code checks if prerenderConfig.allowQuery exists before calling .includes(), but it doesn't guard against allowQuery being undefined when pushing the ISR parameter. If allowQuery is undefined, line 477 will throw a TypeError.

Apply this diff to properly initialize or guard the array:

-  if (
-    prerenderConfig.allowQuery &&
-    !prerenderConfig.allowQuery.includes(ISR_URL_PARAM)
-  ) {
-    prerenderConfig.allowQuery.push(ISR_URL_PARAM);
-  }
+  if (prerenderConfig.allowQuery) {
+    if (!prerenderConfig.allowQuery.includes(ISR_URL_PARAM)) {
+      prerenderConfig.allowQuery.push(ISR_URL_PARAM);
+    }
+  } else if (prerenderConfig.passQuery) {
+    prerenderConfig.allowQuery = [ISR_URL_PARAM];
+  }

Alternatively, if allowQuery should always include ISR_URL_PARAM when ISR is configured:

-  if (
-    prerenderConfig.allowQuery &&
-    !prerenderConfig.allowQuery.includes(ISR_URL_PARAM)
-  ) {
-    prerenderConfig.allowQuery.push(ISR_URL_PARAM);
-  }
+  if (!prerenderConfig.allowQuery) {
+    prerenderConfig.allowQuery = [];
+  }
+  if (!prerenderConfig.allowQuery.includes(ISR_URL_PARAM)) {
+    prerenderConfig.allowQuery.push(ISR_URL_PARAM);
+  }

Likely an incorrect or invalid review comment.

test/presets/vercel.test.ts (2)

116-150: LGTM! Test fixtures updated to reflect new ISR parameter.

The test expectations correctly verify that ISR routes use __isr_route in both source capture groups and destination query strings, aligning with the centralized constant.

---

463-463: LGTM! Prerender config expectation updated.

The test correctly verifies that __isr_route is included in the allowQuery array alongside user-facing query parameters.

src/presets/vercel/runtime/vercel.ts (3)

3-8: LGTM! Necessary imports for ISR-aware routing.

The imports correctly bring in route rules lookup, query manipulation utilities, and the centralized ISR parameter constant.

---

38-38: LGTM! Preserves non-ISR query parameters.

The use of withQuery(url, params) correctly preserves user-facing query parameters when reconstructing the URL for the passQuery flow, which addresses the issue described in #1880.

---

26-33: The non-null assertions are safe but redundant.

In Node.js HTTP request handlers, req.url is always defined by the HTTP specification and guaranteed to be set when the request object is created. The h3 framework maintains this contract. The non-null assertions on lines 26, 30, and 33 are technically unnecessary since req.url will always have a value in this context. Consider removing the ! operators for cleaner code, though the current implementation is functionally correct.