Repository navigation
ninja_syntax: escape paths in Writer.default - #2837
Merged
jhasse merged 1 commit intoOct 9, 2026
Merged
Conversation
Writer.build already runs escape_path on outputs and inputs, but Writer.default joined paths raw. A single default target with a space was therefore emitted as two defaults. Use escape_path for each path, matching the rest of the Writer API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writer.buildalready runsescape_pathon outputs and inputs, butWriter.defaultjoined paths raw. A single default target with a space was therefore emitted as two defaults.Use
escape_pathfor each path, matching the rest of the Writer API. Suggested on #990 (and in closed #1067).The added tests fail on the unpatched helper (
default foo barwith a space) and pass with this change.