Replace pipes.quote with shlex.quote in configure.py #2340
Merged
jhasse merged 2 commits intoninja-build:masterfrom Oct 14, 2023
Merged
Replace pipes.quote with shlex.quote in configure.py #2340jhasse merged 2 commits intoninja-build:masterfrom
jhasse merged 2 commits intoninja-build:masterfrom
Conversation
Python 3.12 deprecated the pipes module and it will be removed in Python 3.13. In configure.py, I have replaced the usage of pipes.quote with shlex.quote, which is the exactly same function as pipes.quote. For more details, refer to PEP 0594: https://peps.python.org/pep-0594
|
It would be rally good to release new version because this commit. |
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 deprecated the pipes module and it will be removed
in Python 3.13. In configure.py, I have replaced the usage of
pipes.quotewith
shlex.quote, which is exactly the same function aspipes.quote.For more details, refer to PEP 0594: https://peps.python.org/pep-0594