Fix check of filename length #2321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
reviewed
May 4, 2024
orgads
added a commit
to orgads/ninja
that referenced
this pull request
May 4, 2024
It causes the cursor handling to be extremely slow on MinGW. Added in ninja-build#2321. Fixes ninja-build#2435.
orgads
added a commit
to orgads/ninja
that referenced
this pull request
May 5, 2024
It causes the cursor handling to be extremely slow on MinGW. Added in ninja-build#2321. Fixes ninja-build#2435. (cherry picked from commit 3d1a5fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix check of filename length in
RealDiskInterface::Statwhen long paths support in Windows is enabled.Add the application manifest to the
ninja_testexecutable target to enable long paths support during tests.Add the test case
DiskInterfaceTest.StatExistingFileWithLongPath.Address #2266 (
Filename longer than 260 characterserror).