Skip to content

Split options module into options and optionsutils#9160

Closed
PMunch wants to merge 3 commits intonim-lang:develfrom
PMunch:optionssplit
Closed

Split options module into options and optionsutils#9160
PMunch wants to merge 3 commits intonim-lang:develfrom
PMunch:optionssplit

Conversation

@PMunch
Copy link
Copy Markdown
Contributor

@PMunch PMunch commented Oct 3, 2018

As discussed under #8358 to add onything fancy to options it should be split into options and optionsutils. This PR is a dependency for future ones that adds functionality to this new module.

@dom96
Copy link
Copy Markdown
Contributor

dom96 commented Oct 4, 2018

As discussed under #8358 to add onything fancy to options it should be split into options and optionsutils.

Can you point me to where exactly this was discussed?

@PMunch
Copy link
Copy Markdown
Contributor Author

PMunch commented Oct 4, 2018

Hmm, seems like the discussion on GitHub around the topic was limited to this comment. Must've been primarily on IRC then, but looking through the logs to find out where could take a while.

@dom96
Copy link
Copy Markdown
Contributor

dom96 commented Oct 5, 2018

That comment doesn't seem to mention anything about putting this stuff in a separate module.

@PMunch
Copy link
Copy Markdown
Contributor Author

PMunch commented Oct 5, 2018

Oh sorry, I misunderstood. That was Araqs suggestion, again back on IRC

@Araq
Copy link
Copy Markdown
Member

Araq commented Oct 11, 2018

There is a better way to do this, stay tuned...

narimiran added a commit to narimiran/Nim that referenced this pull request Mar 6, 2019
@narimiran
Copy link
Copy Markdown
Member

narimiran commented Aug 13, 2019

Since PR #10797 (which was basically a continuation of this one) was rejected, can/should we also close this one?

Also, we should decide what to do with the two PRs following this one:

@PMunch
Copy link
Copy Markdown
Contributor Author

PMunch commented Aug 13, 2019

I've since created a package that implements all these things, which should be available in Nimble. So I'm fine with closing all the PRs for now.

@narimiran
Copy link
Copy Markdown
Member

Thanks @PMunch, closing this and the related PRs.

@narimiran narimiran closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants