Fix #10630 - fix broken separators in nim doc#11814
Merged
narimiran merged 4 commits intonim-lang:develfrom Jul 24, 2019
genotrance:osseps
Merged
Fix #10630 - fix broken separators in nim doc#11814narimiran merged 4 commits intonim-lang:develfrom genotrance:osseps
narimiran merged 4 commits intonim-lang:develfrom
genotrance:osseps
Conversation
narimiran
pushed a commit
that referenced
this pull request
Aug 12, 2019
| const | ||
| CurDir* = | ||
| when defined(macos): ':' | ||
| elif defined(genode): '/' |
Member
There was a problem hiding this comment.
@Araq @genotrance @ehmry is / (instead of .) for indicating current dir correct for genode ? couldn't find any info on the web regarding that; I'm asking since this change wasn't mentioned in this PR and it looks strange
There was a problem hiding this comment.
Yes, I was the one that set it to /. I think the reasoning was that without a libc the current working directory can only be /.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #10629 implementation was rejected, this style was agreeable to Araq.
I have leveraged code from compiler/platform.nim which was more expansive. There are variations though which I have highlighted in comments. Please review.
Note that RISCOS is not in platform.nim.