Skip to content

Commit 6f2fffd

Browse files
authored
chore(deps): pin Node 24.21.0 to stop the Windows worker crash (#1444) (#1472)
* chore(deps): pin Node 24.21.0 in .nvmrc (#1444) Node 24.15.0 has a Windows-only stack buffer overrun in its TCP code (nodejs/node#62991, fixed in 24.16.0). It kills a Vitest worker with exit code 3221226505 during a WebSocket connect, so settings-window-server.test.ts failed about one local run in four. 24.21.0 is the Node 24 that Stream Deck ships, and measured 0 crashes in 600 runs against 27 in 600 on 24.15.0. CI runs on ubuntu and is unaffected by the bug, but reads the same pin. Related to #1444 * docs(rules): name the 0xC0000409 worker crash and its fix (#1444) A worker exiting 3221226505 sent #1084 and #1444 into bisects of the test file list. The cause is Node 24.15.0, so the first check is node -v, not a pool or isolation setting. Fixes #1444 * docs(rules): link the upstream issue that matches the crash (#1444) nodejs/node#63620 is the libuv Windows TCP-connect stack buffer overrun itself, fixed by #62561 in 24.16.0; #62991 only reached it second-hand through an npm ci crash report. Related to #1444 * docs(rules): say which crash measurement used repo code (#1444) The 27/600 replay ran outside vitest but through the server code; only the bare http + ws loop had none. Related to #1444
1 parent 95f2433 commit 6f2fffd

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎.claude/rules/testing.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ Three things to know:
3636

3737
Whether this removes the cause of #1084 is **unestablished**; it removes a path that could produce it.
3838

39+
## A worker that dies with exit code 3221226505 (#1444)
40+
41+
`Worker exited unexpectedly with exit code 3221226505` (0xC0000409) with no stderr, on Windows, is Node 24.15.0's own stack buffer overrun in libuv's Windows TCP-connect path, fixed in 24.16.0 ([nodejs/node#63620](https://github.com/nodejs/node/issues/63620), fix [#62561](https://github.com/nodejs/node/pull/62561)). It strikes during a WebSocket connect, so it showed as `settings-window-server.test.ts` failing in about one full run in four. Measured 2026-10-20 outside vitest: 0 crashes in 600 runs on 24.21.0 and 20.20.2, against 27 in 600 on 24.15.0; a bare `http` + `ws` loop with no repo code crashes on 24.15.0 too. **Check `node -v` before anything else**: `.nvmrc` pins 24.21.0, the Node 24 that Stream Deck ships, and a local Node older than 24.16.0 brings the crash back. A `pool` or `isolate` setting cannot fix it. The #1084 dropped workers began after 24.15.0 was pinned (#928) and were probably the same bug; no exit code was recorded, so that link is unproven.
42+
3943
## Root `vitest.config.ts` — native config loader
4044

4145
`pnpm test` / `pnpm test:watch` pass `--configLoader native`, so Node imports the root `vitest.config.ts` directly and strips its types itself, rather than Vite bundling the config first (Vite 8 bundles it with rolldown, and emits ESM here because the root package is `"type": "module"`) (issue #1017). Vite has announced that loader as a future default; opting in early means a dependency bump can't flip it for us.

‎.nvmrc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
24.15.0
1+
24.21.0

0 commit comments

Comments
 (0)