Repository navigation
fix(missions): project global list summaries from authoritative records - #2618
Merged
Merged
Conversation
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mission record update succeeds but updating its global index fails, the global list still shows the old title, status, updatedAt and lastRunId. Project records are the source of truth, so build those summary fields from the validated record that listGlobalMissions already reads. A record with no runs also clears an obsolete index lastRunId.
Keep pointer identity checks and existing corrupt/missing-record handling. This changes only the returned projection; it adds no reads, scans or index writes.
Validation: all four mission unit test files passed (36 tests), including a real record/index rename EIO regression, healthy controls, sorting and stale lastRunId handling. Typecheck and diff checks passed. A broader combined full-suite run had five failures also reproduced on the unchanged base (a permission-sensitive fixture and orphan-process teardown); it was not a clean full-suite pass. Windows was not tested locally.