Skip to content

fix(cache): invalidate stdio metadata on env mode changes - #687

Merged
nicobailon merged 2 commits into
mainfrom
backlog/pr-683-promotion
Sep 27, 2026
Merged

nicobailon merged 2 commits into
mainfrom
backlog/pr-683-promotion

Conversation

@nicobailon

Copy link
Copy Markdown
Owner

Summary

  • Include effective stdio inheritEnv and literalEnv modes in metadata-cache identity.
  • Hash literal stdio environment values without host interpolation.
  • Preserve URL and Unix-socket cache identities.

This is a current-main promotion of #683. It preserves @kojizada490-wq’s implementation commit and adds visible changelog credit. The original fork branch was not modified.

Validation

  • npx vitest run __tests__/direct-tools.test.ts
  • npm run typecheck
  • git diff --check

Review evidence

Fresh semantic review found no cache-identity defect. After rebasing over #686, executable files match the clean current-base composition of #683; only changelog conflict resolution and contributor credit differ.

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes how tool metadata cache validity is determined.

The PR appears safe to merge; no actionable regression was identified.

Summary

The PR makes stdio metadata-cache identity reflect effective environment inheritance and literal-value modes.

  • Literal stdio environment values are hashed without host interpolation.
  • Tests cover mode changes, built-in Agent Plugins, and preservation of URL and Unix-socket identities.

Reviews (1) · Last reviewed commit: "docs(changelog): credit metadata cache f..."

@nicobailon
nicobailon merged commit 34df4ed into main Sep 27, 2026
4 checks passed
@nicobailon
nicobailon deleted the backlog/pr-683-promotion branch September 27, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants