Repository navigation
Conversation
|
Owner
|
Thanks @kojizada490-wq — this fix landed in #686 on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search searchfrom being treated as partially unmatchedProblem
matchedTokensis aSet, while coverage used the originalqueryTokens.length. For a query likesearch search, the matched-token numerator was deduplicated to 1 while the denominator remained 2, producing 50% coverage and filtering an otherwise matching tool.Validation
npx vitest run __tests__/search-ranking.test.tsnpm run typecheckThe focused regression test fails on current
mainbefore the fix and passes with this change.