Skip to content

Adding assets in compiler.plugin('emit') state - not appearing in manifest #5

Open

Description

@lgordey

Hi @nickjj

I solved some problems with plugin, but it already didn't appearing in manifest.json.

You can see it here - https://github.com/lgordey/webpack-plugin.

I think problem is in Compilation instance of webpack, but maybe you know why thats not working.

Thanks!

Activity

  1. lgordey commented on Jul 22, 2015

    @lgordey
    Author

    I think the reason is because you taking assets from data.modules and not from data.assets.
    So added assets from other plugins in this case will not appear in manifest.json.

  2. lgordey commented on Jul 22, 2015

    @lgordey
    Author
    var data = stats.toJson(options);
    

    data.assets :
    image

    data.modules:
    image

    Second screen is very big, but u can see, that there is no my-sprite in modules.name section

  3. nickjj commented on Jul 22, 2015

    @nickjj
    Owner

    I believe in the assets section, it included css and js files but the modules section omits them.

  4. lgordey commented on Jul 22, 2015

    @lgordey
    Author

    Modules section doesn't include dynamically added assets - that's the problem.

  5. lgordey commented on Jul 24, 2015

    @lgordey
    Author

    I think it is a webpack issue at first.

    Cause in current situation we can't show in manifest assets that have been added from another plugins.

    You can read linked issue.

  6. nickjj commented on Jul 24, 2015

    @nickjj
    Owner

    Thanks for putting so much time into this issue. I wonder what will come from it on the webpack side.

  7. lgordey commented on Jul 24, 2015

    @lgordey
    Author

    I created pull request (webpack/webpack#1291) to create field that contains path, so you can take assets from stats.assets, I hope it will be approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions