Ignore Cargo.lock#50
Merged
cburgdorf merged 1 commit intonickel-org:masterfrom Aug 3, 2014
janpantel:cargo_lock
Merged
Conversation
Member
|
Thanks |
|
@janpantel Why should Cargo.lock be ignored? I currently can't find any documentation on it, but if it's like Gemfile.lock for Ruby's Bundler, it should be added to the repository because it allows a consistent set of dependency versions to be used (until explicitly updated with |
ghost
mentioned this pull request
Member
|
I just read up on what the Gemfile.lock is and I tend to agree that we should put it into version control. However @steveklabnik and @wycats, according to this thread think it should only be checked in for bin projects, not libs. |
Contributor
Author
|
Looking at this from the PHP perspective it's the same approach... Ignore the Composer.lock for lib and check in for 'bin' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo has introduced the Cargo.lock file. This should be ignored :)