-
-
Notifications
You must be signed in to change notification settings - Fork 396
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
The behavior of this implementation was changed slightly with the switch to EXTCODEHASH. Let's document this using test cases.
Mocks:
- Contract R
- Has a token receive function which emits an event Received
- Contract A
is R- Has constructor
- Deploys NFToken
- Mints token id=1
- Transfers token id=1 to self
- Has constructor
- Contract B
- Has constructor
- Deploys NFToken
- Deploys R
- Transfers token id=1 to R
- Has constructor
Tests:
- Test 1
- Transaction 1 -- Deploy NFToken
- Transaction 2 -- Mint token id=1
- Transaction 3 -- Deploy Contract R
- Transaction 4 -- Transfer token id=1 to R
- Expect NO event on Constantinople
- Test 2
- Transaction 1 -- Deploy NFToken
- Transaction 2 -- Mint token id=1
- Transaction 3 -- Deploy Contract R
- Expect NO event on Constantinople
- Test 3
- Transaction 1 -- Deploy Contract B
- Expect event on Constantinople (but no event with same test using old version of implementation)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request