You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d74f49e
Browse filesBrowse the repository at this point in the historyBrowse files
// This file has modifications to global types used for nimble-components builds:
2
+
// - The types file should not be in the build output
3
+
// - You should not see a file with these types created in the dist build
4
+
// - Type additions added to this file should not appear in any public API definitions
5
+
// - The fields added to global types should not be observable in any built .d.ts file by TypeScript. To verify you can do a text search of generated .d.ts files in the dist folder for the fields being added and verify they are not associated with the augmented types.
6
+
// - This file should only impact the nimble-components library build and not users of nimble-components. Any type changes that impact clients should not be placed here.
7
+
8
+
/**
9
+
* This is a workaround for an incomplete definition of the native dialog element. Remove when using Typescript >=4.8.3.
// roundingPriority has been supported by browsers since 8/23, but TypeScript still hasn't
20
+
// added it to the type definition. See https://github.com/microsoft/TypeScript/issues/56269
@@ -33,10 +32,14 @@ export class DecimalUnitFormat extends UnitFormat<DecimalUnitFormatOptions> {
33
32
}
34
33
){
35
34
super();
35
+
// Workaround to avoid a ts error about signDisplay not accepting the value 'negative'.
36
+
// It has been supported by browsers since 8/23, but TypeScript still hasn't
37
+
// added it to the type definitions. See https://github.com/microsoft/TypeScript/issues/56269
// Workaround to avoid ts errors about signDisplay not accepting the value 'negative'.
7
+
// It has been supported by browsers since 8/23, but TypeScript still hasn't
8
+
// added it to the type definitions. See https://github.com/microsoft/TypeScript/issues/56269
0 commit comments