Repository navigation
Add callback for extendmaxdata - #2283
Merged
Merged
Conversation
Contributor
Author
|
We discussed #2243 in the node.js quic meeting. |
tatsuhiro-t
reviewed
Aug 15, 2026
| rv = conn_call_extend_max_data(conn, conn->tx.max_offset); | ||
| if (rv != 0) { | ||
| return rv; | ||
| } |
Member
There was a problem hiding this comment.
Please do not call it here. See the above comment.
martenrichter
force-pushed
the
callbackmaxdata
branch
from
August 15, 2026 14:58
023a113 to
5f4aa29
Compare
Contributor
Author
|
Ok, I have correct the things you requested and then did a force push so that the history is clean. |
martenrichter
force-pushed
the
callbackmaxdata
branch
from
August 15, 2026 15:01
5f4aa29 to
96dae61
Compare
martenrichter
commented
Aug 15, 2026
Some users of the library (node.js), require a callback, that signals, when new maxdata values are available, as the maxdata value is cached and evaluated outside ngtcp2. Fixes ngtcp2#2243 Signed-off-by: Marten Richter <[email protected]>
martenrichter
force-pushed
the
callbackmaxdata
branch
from
August 15, 2026 15:06
96dae61 to
cb0cfcf
Compare
tatsuhiro-t
approved these changes
Aug 16, 2026
Member
|
Thank you for PR. Merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users of the library (node.js),
require a callback, that signals, when new
maxdata values are available, as the maxdata
value is cached and evaluated outside ngtcp2.
Fixes #2243